fix(thorvg): fix windows build break #5978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
In response to #5946
Error when building thorvg on Windows. Defined functions were being marked with
__declspec(dllimport)
.lvgl/src/libs/thorvg/thorvg_capi.h
Lines 35 to 40 in fea8a97
This fix tries to leave the thorvg header untouched except for defining
TVG_BUILD
at the top so it's easier to update thorvg from the upstream. #4691 (comment)Would have been found by the eventual Windows CI #5904
Also remove duplicate guard.
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.