-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): Windows MSVC and GCC build #6015
Conversation
Very nice! It would be great to reuse the CMake files for MSVC too, but if there is more Windows-ish way we can choose that too. @MouriNaruto could you take a look at the Windows driver related changes? |
@kisvegabor I have read the changes. I think @liamHowatt should move the device window message handler declarations back because these are private interfaces. For LVGL Windows backend, I try my best to maintain the ABI compatibility. So, I don't hope to see making some private interfaces to be public. (The lv_windows_input.h and lv_windows_display.h only contain the public API. The lv_windows_context.h only contains the context-related private APIs.) Kenji Mouri |
Thanks for the feedback @MouriNaruto. In hindsight I see that those handlers should not be the header as you say. I originally did it to fix a CI warning. https://github.com/liamHowatt/lvgl/actions/runs/8527506893/job/23359087388
Generally it's good to only-declare-once. Recently we've been moving private cross-file declarations to |
If @MouriNaruto agrees with having |
@kisvegabor I'm agree with having lv_windows_input_private.h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@liamHowatt I think you should do some macro checks for GCC-specific progma to keep the MSVC compatibility. Kenji Mouri |
Will you migrate to MSVC still in this PR? |
Yep, good idea.
That wasn't the intent of this PR but yes I will. It is important. |
Yes, I think MinGW is not so interesting compared to MSVC. |
There is now an MSVC build workflow.
|
Thank you! At some point it would be nice to lower the number of the remaining warnings, but at least now we know that LVGL builds on MSVC too! 🎉 |
Description of the feature or fix
See #5904 and #5978
Add a CI test for building on Windows. In particular, build the Windows-specific files from #5313.
Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.