-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/stacked area chart example #2507
Feat/stacked area chart example #2507
Conversation
The example shows how to use a line chart and masking to create a stacked area chart.
Updated index.rst to contain the stacked area chart example
Coding style changes
Added axis ticks
@kisvegabor I think this is unrelated to the example, but there is an extra pixel being drawn at the top of each section on the right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks great; I just have a couple comments.
This is because of the If I remove the |
@tomhepworth Any plans to add Micropython example? ( |
I have never used micropython but I can give it a go. |
Great! |
Responses to PR comments - Changed to fixed point maths - Renamed variables and filenames
I pushed my fixes but for some reason the PR doesn't seem to want to synchronize with my branch. |
Weird, I've never seen that happen before. Perhaps try a force push? We typically squash PRs when merging anyways, so the exact commits on your branch don't matter. |
Seems ok now |
Made shift amount a variable.
Fixed typo in changelog
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sorry for the late reply. GitHub doesn't send notifications on edits so I haven't seen the update. Although the MicroPython version is still missing I merge it. @tomhepworth thank you for adding this example. |
Description of the feature or fix
An example of how to use a line chart + masking to create a simple stacked area chart as discussed here: https://forum.lvgl.io/t/line-masking-to-create-a-stacked-area-chart/6558/6
Checkpoints