feat(tools): Python script for automatically applying version (#6012) #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisvegabor
reviewed
Apr 17, 2024
| description='Apply the specified version to affected source files') | ||
| parser.add_argument('version', metavar='version', type=str, | ||
| help='The version to apply') | ||
|
|
There was a problem hiding this comment.
Please add a help too with usage example(s).
scripts/update_version.py
Outdated
|
|
||
|
|
||
| class Version: | ||
| RE_PATTERN = r"(\d+)\.(\d+)\.(\d+)(-dev)?" |
There was a problem hiding this comment.
Do not limit it to -dev.
Suggested change
| RE_PATTERN = r"(\d+)\.(\d+)\.(\d+)(-dev)?" | |
| RE_PATTERN = r"(\d+)\.(\d+)\.(\d+)(-a-zA-Z0-9)?" |
becseya
force-pushed
the
feature/6012_release_script
branch
from
4cb67f3
to
9ec684c
Compare
|
Great, thank you! I hope #5865 will be merged soon. |
becseya
force-pushed
the
feature/6012_release_script
branch
2 times, most recently
from
6a61911
to
35b0475
Compare
|
Updated |
kisvegabor
reviewed
Apr 24, 2024
|
Does it need to be cherry-picked to other release branches? |
|
I think no for now. |
XuNeo
previously approved these changes
Apr 29, 2024
|
How can we test such a script? |
This was referenced May 1, 2024
becseya
force-pushed
the
feature/6012_release_script
branch
from
35b0475
to
6f13cc2
Compare
|
It was tested manually for several version variants. I'd go with that, writing test cases for such a small script feels extensive. |
FASTSHIFT
approved these changes
May 4, 2024
XuNeo
approved these changes
May 4, 2024
|
Not all questions are clear about updating version numbers but I merge it now to make some order. Probably a follow up PR will be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6012