fix(docs): pull version out of lv_version.h in python #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2024 20:34
This reverts commit 5894d53.
Pull version out of lv_version.h in python instead of calling a shell script, to retain compatibility with various platforms. Signed-off-by: Marek Vasut <marex@denx.de>
|
It would be nice to use the same script on multiple places to simplify maintenance. What about converting |
This was referenced Apr 28, 2024
|
I will make the changed needed and submit a PR for it. |
@kisvegabor I assume #6080 is already implementing that ? |
|
I'd suggest closing this PR as #6143 contains the (functionally) same change |
|
Closing in favor of #6143 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull version out of lv_version.h in python instead of calling
a shell script, to retain compatibility with various platforms.
Paging @embeddedt and @kisvegabor . This revert is not great, sorry. I suspect this will fix breakage for @kdschlosser .