Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): fix the issue of needle sliding in scale #6343

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

lhdjply
Copy link
Contributor

@lhdjply lhdjply commented Jun 8, 2024

Description of the feature or fix

@liamHowatt @C47D

#6320 fixed the sliding issue of lv_example_scale_3(). But I found that in lv_demo_widgets(), this issue still occurs when the window is maximized first and then zoomed out (see video below).Therefore, it is best to integrate directly into lv_scale_set_image needle_value

416137c29d72090dac256463069cb9c7.mp4

Notes

Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice!

I wonder if it belongs in the constructor? Other widgets remove/add flags in their constructors. What do you think?

Examples: roller, button

Signed-off-by: lhdjply <lhdjply@126.com>
@lhdjply
Copy link
Contributor Author

lhdjply commented Jun 11, 2024

I wonder if it belongs in the constructor? Other widgets remove/add flags in their constructors. What do you think?

This way of modification is indeed better. Done.

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lhdjply lhdjply requested a review from liamHowatt June 11, 2024 10:54
Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kisvegabor kisvegabor merged commit 7802201 into lvgl:master Jun 13, 2024
17 checks passed
@lhdjply lhdjply deleted the fix/scale branch June 14, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants