-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into develop #191
Conversation
fix spi names
Revert "fix spi names"
with ESP32-C3 specific auto-dma proper selection
Resolving conflicts
@C47D This PR resolves conflicts between master and develop. It can be successfully build (check GH actions) I'll have to test in on HW before merging, though |
Update: tested and working with ESP32S2 + ST7789 + LVGL v8. I understand that the other drivers were not updated to LVGL v8 yet. |
Hi @tore-espressif, as far as I remember that particular driver is the only one that works with both LVGL v7 and v8. Thanks for taking the time to solve this issue, I know is not very fun to do :) |
Well, I caused the whole problem, it's shame that it took me so long. If this gets merged into develop, do you want to merge develop to master ASAP? As far as I understand it, there will be inconsistencies between drivers. (Related discussion #188) |
Hi, don't worry. We could merge develop into master and firstly fix compilation errors. Then update drivers gradually. What do you think? |
Fair enough 👍 |
Feel free to merge this. |
Closes #146