Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use bold text for feeds/folders with unread items #445

Closed
wants to merge 1 commit into from
Closed

Add an option to use bold text for feeds/folders with unread items #445

wants to merge 1 commit into from

Conversation

ao2
Copy link

@ao2 ao2 commented Nov 10, 2016

This allows to have back the old 1.10 look of the feed list, where
feeds/folders with unread items had bold text.

As highlighted in #29 some
users prefer the old look because it suits better their environment,
however liferea does not support it "publicly" anymore, the option is
provided only for backward compatibility.

Users who wanted the old behavior have to set the GSettings value
"feedlist-unread-items-bold" to true by themselves, using dconf-editor
or with a command like the following:

$ gsettings set net.sf.liferea feedlist-unread-items-bold true

@shartge
Copy link

shartge commented Dec 1, 2016

For what it's worth: I've been running with this patched into the Debian package since October 14 and have not found any problems, glitches or bugs with it.

I personally would be very thankful if this PR could be merged (and hopefully make into the next Debian release on time).

@ao2
Copy link
Author

ao2 commented Dec 30, 2016

Ping

@kotnik
Copy link

kotnik commented Feb 13, 2017

I hope this patch will get into the next release, it significantly improves readability and processing of feeds, especially if you have a lot of feeds in a folder.

@ao2
Copy link
Author

ao2 commented Feb 15, 2017

@lwindolf any comments about this?

Thanks,
Antonio

@carrotIndustries
Copy link

*bump* I'd really like to see this PR merged, since I assumed the non-bold unread feeds were a bug.

@kotnik
Copy link

kotnik commented Apr 5, 2017

Sad that this didn't make it into 1.12-rc3 release :(

@ao2
Copy link
Author

ao2 commented May 18, 2017

Ping.

This allows to have back the old 1.10 look of the feed list, where
feeds/folders with unread items had bold text.

As highlighted in #29 some
users prefer the old look because it suits better their environment,
however liferea does not support it "publicly" anymore, the option is
provided only for backward compatibility.

Users who wanted the old behavior have to set the GSettings value
"feedlist-unread-items-bold" to true by themselves, using dconf-editor
or with a command like the following:

  $ gsettings set net.sf.liferea feedlist-unread-items-bold true
@jekhor
Copy link

jekhor commented Jun 28, 2017

+1 vote for merging this

@yaneti
Copy link
Contributor

yaneti commented Aug 18, 2017

Tried a plugin approach in pull request #532 that mught be more acceptable..

@ao2
Copy link
Author

ao2 commented Aug 23, 2017

@yaneti thanks, I haven't tested it yet but an external plugin looks acceptable to me too as a solution, if the core patch gets rejected.

Thanks,
Antonio

@lwindolf
Copy link
Owner

lwindolf commented Sep 3, 2017

As @yaneti contributed a plugin which works fine, I'm closing this PR. I hope everyone is ok with it!

@lwindolf lwindolf closed this Sep 3, 2017
@lwindolf lwindolf self-assigned this Sep 3, 2017
@lwindolf lwindolf added this to the 1.12.0 milestone Sep 3, 2017
@ao2
Copy link
Author

ao2 commented Sep 18, 2017

OK, I tested the plugin and it work really well, thanks @yaneti.

@lwindolf if you could tag an rc4, distributions will update their packages and more users will benefit from the plugin.

Thanks,
Antonio

@ao2 ao2 deleted the feedlist-unread-items-bold branch September 18, 2017 09:41
@lwindolf
Copy link
Owner

@ao2 I'm aiming for the 1.12.0 actually :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants