-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to display the URL as a QR code #148
Comments
Interesting... for development porpuses this could be really useful. What do you think @75lb ? |
yes, Which URL should the QR encode? When you run
Which of these URLs should the QR represent? We need to pass in an argument which identifies which URL to display as QR.
Please implement in lws. You'll need to update the built-in cli-view.
|
Nice! I'm going to work on this. If the user does not pass any argument we could print by default the URL that matches one of the IETF private address because that's probably the address the user is looking for when scanning with an external device that is in the same private (wi-fi) network. Right? |
Yes, that sounds like a sensible default - using a mobile device on the same LAN is a common use case. Would that default also work when both your laptop and mobile device are connected to a mobile network? Would be a bonus if so. |
Like the laptop using the mobile as a hotspot, right? |
@larryw3i this issue is being built and discussed here lwsjs/lws#13 |
Released in v4.1.0. Cheers! 👍 |
Maybe generating qrcode is been needed, it's convenient if get my laptop files just scan the qrcode
The text was updated successfully, but these errors were encountered: