feat: server address printed as QR Code upon server startup #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole.log) Remove superfluous 'Scan this QR' message. If the user has specified --qr they already realise they need to scan a QR.
|
Good work, thanks. Happy with the changes? |
|
Yeah.! I agree with all of them and specially the command line instructions are much cleaner now. If you need any help, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13 originally referenced in lwsjs/local-web-server#148
Shortly:
--qrprints the QR Code of the first server address that matches a private network address---qr <iface>prints the QR Code of the network interface passed as argIf no
--qrparam is passed the QR Code is not printed, which is the default behavior.Tests and Coverage implemented