fix incorrect status code from runCommandStatus #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the patch. You need to sign-off your commit though. :) |
|
Hi @brauner, how do i sign-off? |
|
at the end of your commit message. |
|
@brauner done, thanks |
runCommandStatus should return correct status codes (use of WEXITSTATUS macro) as lxc-execute does in https://github.com/lxc/lxc/blob/master/src/lxc/tools/lxc_execute.c#L239 Signed-off-by: s3rj1k <evasive.gyron@gmail.com> [christian.brauner@ubuntu.com: mirror WEXITSTATUS() correctly] Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
|
Hm, on second thought this might break existing users since this changes the behavior of |
|
@brauner would this impact LXD? That's the only major project with stable releases out there where we may really need to be careful about potentially breaking all exit codes. |
|
LXD does not call any of those functions currently. So, no. Feel free to merge then. |
|
Okay, sounds worth fixing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runCommandStatus should return correct status codes (use of WEXITSTATUS macro)
as lxc-execute does in https://github.com/lxc/lxc/blob/master/src/lxc/tools/lxc_execute.c#L239