Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPYING states GPLv3 in official lxc 4.0.3 tarball #3484

Closed
ffontaine opened this issue Jul 15, 2020 · 7 comments · Fixed by #3486
Closed

COPYING states GPLv3 in official lxc 4.0.3 tarball #3484

ffontaine opened this issue Jul 15, 2020 · 7 comments · Fixed by #3486

Comments

@ffontaine
Copy link
Contributor

The official lxc 4.0.3 tarball (https://linuxcontainers.org/downloads/lxc/lxc-4.0.3.tar.gz) contains a COPYING file with the GPL-3.0 license text. However, from my understanding lxc is mainly licensed under LGPL-2.1+ with some files under GPL-2.0-only. Could you clarify why COPYING is GPLv3?

@stgraber
Copy link
Member

All files have SPDX headers that make it very clear what license they're under.
The repo also ships the full text of both the GPLv2 and LGPLv2.1 license.

COPYING as interpreted by Github and other platforms does not support specifying varied licenses based on files, therefore it makes sense for it to be the most restrictive license, so folks don't mistakenly copy code from the coebase thinking it's all LGPLv2.1 based on COPYING.

Instead they'll either be fine with it being GPLv2 in which case LGPLv2.1 is fine too, or they'll look at the license of the actual code they're using to see if it's less restrictive than the default.

@tpetazzoni
Copy link
Contributor

I think the point of the question is: does it make sense for the COPYING file to contain the GPLv3 text, if there is nothing under GPLv3 in your project ? Having COPYING contain the GPLv2 text would be more sensible if we follow the reasoning you have outlined.

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue Jul 16, 2020
Commit 5a39367 forgot to update
license which has been changed from COPYING to LICENSE.GPL2 and
LICENSE.LGPL2.1 since version 4.0.0 and
lxc/lxc@cc73685

It should be noted that COPYING describes GPLv3, see upstream answer
here: lxc/lxc#3484

Fixes:
 - http://autobuild.buildroot.org/results/2da182d0b84e2597e135506f8166a54660c4b2f5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
@brauner
Copy link
Member

brauner commented Jul 16, 2020

I think the point of the question is: does it make sense for the COPYING file to contain the GPLv3 text, if there is nothing under GPLv3 in your project ? Having COPYING contain the GPLv2 text would be more sensible if we follow the reasoning you have outlined.

The COPYING file is autogenerated it seems. We have never consciously used GPL v3 anywhere nor generated it. Do you have a patch to prevent this?

@ffontaine
Copy link
Contributor Author

The COPYING file is added to the official tarball because automake --add-missing is called in autogen.sh:

It should be noted that automake already displays the following warning:

Makefile.am: installing './COPYING' using GNU General Public License v3 file
Makefile.am:     Consider adding the COPYING file to the version control system
Makefile.am:     for your code, to avoid questions about which license your project uses

So, the easiest way to fix this "issue" is to add back a simple COPYING file containing a single sentence explaining that:

All files have SPDX headers that make it very clear what license they're under.
The repo also ships the full text of both the GPLv2 and LGPLv2.1 license.

@brauner brauner reopened this Jul 16, 2020
brauner pushed a commit to brauner/lxc that referenced this issue Jul 16, 2020
Closes: lxc#3484.
Suggested-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@brauner
Copy link
Member

brauner commented Jul 16, 2020

The COPYING file is added to the official tarball because automake --add-missing is called in autogen.sh:

It should be noted that automake already displays the following warning:

Makefile.am: installing './COPYING' using GNU General Public License v3 file
Makefile.am:     Consider adding the COPYING file to the version control system
Makefile.am:     for your code, to avoid questions about which license your project uses

So, the easiest way to fix this "issue" is to add back a simple COPYING file containing a single sentence explaining that:

All files have SPDX headers that make it very clear what license they're under.
The repo also ships the full text of both the GPLv2 and LGPLv2.1 license.

#3486

Does that look reasonable?

@tpetazzoni
Copy link
Contributor

Sounds reasonable, thanks!

@ffontaine
Copy link
Contributor Author

ffontaine commented Jul 16, 2020

Yes, that looks good, thanks.

nolange pushed a commit to nolange/buildroot that referenced this issue Jul 17, 2020
Commit 5a39367 forgot to update
license which has been changed from COPYING to LICENSE.GPL2 and
LICENSE.LGPL2.1 since version 4.0.0 and
lxc/lxc@cc73685

It should be noted that COPYING describes GPLv3, see upstream answer
here: lxc/lxc#3484

Fixes:
 - http://autobuild.buildroot.org/results/2da182d0b84e2597e135506f8166a54660c4b2f5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
brauner pushed a commit that referenced this issue Jul 18, 2020
Closes: #3484.
Suggested-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
awanga pushed a commit to awanga/alt-f-next that referenced this issue Oct 7, 2020
Commit 5a39367 forgot to update
license which has been changed from COPYING to LICENSE.GPL2 and
LICENSE.LGPL2.1 since version 4.0.0 and
lxc/lxc@cc73685

It should be noted that COPYING describes GPLv3, see upstream answer
here: lxc/lxc#3484

Fixes:
 - http://autobuild.buildroot.org/results/2da182d0b84e2597e135506f8166a54660c4b2f5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants