templates: add lxc-local template #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
Feb 26, 2018
templates/lxc-local.in
Outdated
| [ "$arg" = "--" ] && break | ||
| if [ "$arg" = "--mapped-uid" ] || [ "$arg" = "--mapped-gid" ]; then | ||
| echo "This template can't be used for unprivileged containers." 1>&2 | ||
| echo "You may want to try the \"download\" template instead." 1>&2 |
There was a problem hiding this comment.
Hmm, why? We're only unpacking tarballs, which should be fine unprivileged.
There was a problem hiding this comment.
lxc-usernsexec currently unpacks in a new user namespace. Do we care about device nodes not being created?
There was a problem hiding this comment.
Nope, we don't and we in fact have logic in the download template specifically for this. There's a file in the metadata tarball which lists all the device nodes, those can then be excluded when unpacking the tarball.
There was a problem hiding this comment.
Added relevant_file function.
stgraber
reviewed
Feb 26, 2018
templates/lxc-local.in
Outdated
| [ -h | --help ]: Print this help message and exit. | ||
| [ -l | --list ]: List all available images and exit. | ||
| [ -c | --config ]: List all available images and exit. | ||
| [ -f | --fstree ]: List all available images and exit. |
There was a problem hiding this comment.
Also maybe use metadata instead of config? since it's a tarball that includes more than just the config.
brauner
force-pushed
the
2018-02-16/lxc_local_template
branch
from
454b7c1
to
028df81
Compare
added 2 commits
February 26, 2018 17:04
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Closes lxc#2184. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2018-02-16/lxc_local_template
branch
from
028df81
to
35444f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2184.
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com