seccomp: handle arch inversion #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deals with different kernel and userspace layouts and nesting. Here are three examples: 1. 64bit kernel and 64bit userspace running 32bit containers 2. 64bit kernel and 32bit userspace running 64bit containers 3. 64bit kernel and 64bit userspace running 32bit containers running 64bit containers Two things to lookout for: 1. The compat arch that is detected might have already been present in the main context. So check that it actually hasn't been and only then add it. 2. The contexts don't need merging if the architectures are the same and also can't be. With these changes I can run all crazy/weird combinations with proper seccomp isolation. Closes lxc#654. Link: https://bugs.chromium.org/p/chromium/issues/detail?id=832366 Reported-by: Chirantan Ekbote <chirantan@chromium.org> Reported-by: Sonny Rao <sonnyrao@chromium.org> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
|
Thanks very much for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deals with different kernel and userspace layouts and nesting. Here
are three examples:
Two things to lookout for:
context. So check that it actually hasn't been and only then add it.
With these changes I can run all crazy/weird combinations with proper seccomp
isolation.
Closes #654.
Link: https://bugs.chromium.org/p/chromium/issues/detail?id=832366
Reported-by: Chirantan Ekbote chirantan@chromium.org
Reported-by: Sonny Rao sonnyrao@chromium.org
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com