Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: fix network device removal #2922

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

brauner
Copy link
Member

@brauner brauner commented Apr 2, 2019

Closes #2849.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

Closes lxc#2849.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@brauner
Copy link
Member Author

brauner commented Apr 3, 2019

jenkins: test this please

@stgraber stgraber merged commit 1f6af53 into lxc:master Apr 3, 2019
@nfrntrd
Copy link

nfrntrd commented Apr 3, 2019

@stgraber Should I test this with a snap or did the test case satisfy everything for you? I just created test machine with edge snap @ a577d44 but it didn't include this merge I believe. Should I wait for the next snap edge or do something special?

@stgraber
Copy link
Member

stgraber commented Apr 3, 2019

Next edge snap should get it

@nfrntrd
Copy link

nfrntrd commented Apr 3, 2019

Awesome thanks for the fix! I'm looking forward to be able to use this is a scaled out environment. Always like to give kudos to the people working hard to drive cool technology!

@stgraber
Copy link
Member

stgraber commented Apr 3, 2019

I've pushed a cherry-pick of this fix to the candidate channel too, a new snap should be built with that fix in the next hour or so.

@nfrntrd
Copy link

nfrntrd commented Apr 4, 2019

Congrats team! It works with both OVS and regular linux bridges. Thank you again! Using the snap edge @ f206d38 version

@brauner
Copy link
Member Author

brauner commented Apr 4, 2019

Sweet, thanks for confirming, @nfrntrd. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants