Skip to content

Commit

Permalink
proc_loadavg.c: Fix incompatible integer to pointer conversion
Browse files Browse the repository at this point in the history
Newer compiler like Clang 16 and GCC 14 have certain error enabled by
default, namely -Werror=incompatible-function-pointer-types. Which
resutls in build error such as:

proc_loadavg.c:606:10: error: incompatible integer to pointer conversion returning int from a function with result type pthread_t

My patch supresses the error for now, but a proper fix would be better.
Fist discovered on Gentoo linux (bug #894348).

Bug: https://bugs.gentoo.org/894348
Closes: #561
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
  • Loading branch information
listout authored and stgraber committed Mar 18, 2024
1 parent fcb2484 commit d5ae1d6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/proc_loadavg.c
Expand Up @@ -636,12 +636,12 @@ pthread_t load_daemon(int load_use)

ret = init_load();
if (ret == -1)
return log_error(0, "Initialize hash_table fails in load_daemon!");
return (pthread_t)log_error(0, "Initialize hash_table fails in load_daemon!");

ret = pthread_create(&pid, NULL, load_begin, NULL);
if (ret != 0) {
load_free();
return log_error(0, "Create pthread fails in load_daemon!");
return (pthread_t)log_error(0, "Create pthread fails in load_daemon!");
}

/* use loadavg, here loadavg = 1*/
Expand Down

0 comments on commit d5ae1d6

Please sign in to comment.