bindings: better logging for write_string() #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauner
force-pushed
the
2018-07-30/improve_error_message
branch
from
83e224f
to
10f9497
Compare
|
thanks! @brauner |
Blub
reviewed
Jul 30, 2018
bindings.c
Outdated
| len = strlen(string); | ||
| ret = fwrite(string, 1, len, f); | ||
| if (ret != len) { | ||
| lxcfs_error("Error writing to file: %s\n", strerror(errno)); | ||
| lxcfs_error("%s - Error writing \"%s\" to \"%s\"\n", | ||
| strerror(errno), string ? string : "(null)", |
There was a problem hiding this comment.
I don't think string can be NULL here? Otherwise the strlen(string) and fwrite(string, ...) would already be an issue.
Closes lxc#249. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2018-07-30/improve_error_message
branch
from
10f9497
to
beb5024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #249.
Signed-off-by: Christian Brauner christian.brauner@ubuntu.com