add some metrics for meminfo #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauner
requested changes
Jan 28, 2020
bindings.c
Outdated
| @@ -3544,7 +3604,9 @@ static int proc_meminfo_read(char *buf, size_t size, off_t offset, | |||
| memlimit = get_min_memlimit(cg, "memory.limit_in_bytes"); | |||
| if (!cgfs_get_value("memory", cg, "memory.usage_in_bytes", &memusage_str)) | |||
| goto err; | |||
| if (!cgfs_get_value("memory", cg, "memory.stat", &memstat_str)) | |||
|
|
|||
| mstat = (struct memory_stat *)malloc(sizeof(struct memory_stat)); | |||
There was a problem hiding this comment.
We don't cast
malloc().
thanks for your comment, I have fixed it. please refer to my master branch
|
Can you rebase the branch, please. It currently has merge conflicts with master :) |
dirty/writeback ... and so on Signed-off-by LiMing Wu <19092205@suning.com>
OKI have rebased it. |
brauner
pushed a commit
to brauner/lxcfs
that referenced
this pull request
Feb 27, 2020
dirty/writeback ... and so on Closes lxc#315. Signed-off-by LiMing Wu <19092205@suning.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirty/writeback ... and so on，
improve readabilty of refresh_load
Signed-off-by LiMing Wu 19092205@suning.com