proc: checks system security policy before trying to get personalities #639
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
096972f and fc8f593 introduces task personalities retrieval to fix incorrect /proc files info in some cases. Linux governs access to personalities based on system ptrace policy, which may be restricted by an LSM (e.g. Yama). This patch implements a simple check for init's personality access to make sure ptrace usage is allowed, and prevent access from containers to proc files with "Permission denied" error if not. > closes #636 (follow-up to #553 and #609). Signed-off-by: Samuel FORESTIER <samuel+dev@forestier.app>
HorlogeSkynet
force-pushed
the
check_personality_access_policy
branch
from
06021d2
to
276cc1c
Compare
|
@mihalicyn can you review this one? |
|
please, don't close PR each time when you need to update it. (hint: You can use Previous PR #637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partially) closes #636 (re-submission of #637).