This repository has been archived by the owner on May 1, 2024. It is now read-only.
Expanduser for shares as well as additional share properties. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhaowu
force-pushed
the
expanduser-share-source-path
branch
2 times, most recently
from
3b8bcdf
to
d584992
Compare
|
The error here is due to ansible now requiring python 3.5+. Perhaps we should either fix the version of ansible or stop building for 3.4? |
shuhaowu
force-pushed
the
expanduser-share-source-path
branch
from
d584992
to
a276214
Compare
This allows one to share things like .ssh/.gnupg and other stuff easier into the container.
shuhaowu
force-pushed
the
expanduser-share-source-path
branch
from
a276214
to
82815c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
- Coverage 91.72% 91.33% -0.4%
=========================================
Files 45 45
Lines 1293 1304 +11
=========================================
+ Hits 1186 1191 +5
- Misses 107 113 +6
Continue to review full report at Codecov.
|
shuhaowu
force-pushed
the
expanduser-share-source-path
branch
2 times, most recently
from
b7206e3
to
1154d2e
Compare
Any options as exposed by LXD [1] is supported. This allows a mount to be optional/readonly/etc. [1]: https://github.com/lxc/lxd/blob/65cec7f2c884ea2490fe9376d10abe8aefa97b84/doc/containers.md#type-disk
shuhaowu
force-pushed
the
expanduser-share-source-path
branch
from
1154d2e
to
e1faae2
Compare
shuhaowu
changed the title
|
Any updates on this? I'm working on a number of features for lxdock and this is going make it difficult to maintain my patches to be upstreamable as there are so many of them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows shares to be specified with ~ on the host.
This allows one to share things like .ssh/.gnupg and other stuff easier into the container.
Additionally, I'm adding an entry to allow the specification of additional disk options as documented by https://github.com/lxc/lxd/blob/master/doc/containers.md#type-disk
@robvdl