-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multi language support. The language can now be switched (Need translation) #216
Open
HumansAreWeak
wants to merge
10
commits into
lxgr-linux:master
Choose a base branch
from
HumansAreWeak:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 11, 2022
-
Added potential multi language support. The selected language itself …
…is not yet saved in the settings storage. I also started the translation process, by removing hardcoded strings and replacing them with keys, so they are found in the JSON files. And lastly added a new menu entry, which looks really messy, but changing the language works.
Configuration menu - View commit details
-
Copy full SHA for 01d6a5b - Browse repository at this point
Copy the full SHA 01d6a5bView commit details
Commits on Jul 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5ca7a89 - Browse repository at this point
Copy the full SHA 5ca7a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11242cb - Browse repository at this point
Copy the full SHA 11242cbView commit details -
I changed the language class a bit, instead of using the settings ins…
…tance directly in the class, it is passed in as parameter (DI), so I could test the class properly. Furthermore I have added a new method in the Settings class to get the setting via a method call, instead of relying on magic functions. I have also added a fallback language (en_US), which can be modified in the constants.py file, to load these language strings if no translation can be found in the current language file.
Configuration menu - View commit details
-
Copy full SHA for b9eead8 - Browse repository at this point
Copy the full SHA b9eead8View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb5f342 - Browse repository at this point
Copy the full SHA eb5f342View commit details
Commits on Jul 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 80db693 - Browse repository at this point
Copy the full SHA 80db693View commit details
Commits on Aug 5, 2022
-
Added more translation stuff and removed hardcoded strings
I may have added some additional whitespaces in the used data structures. But I think that is not such a huge problem.
Configuration menu - View commit details
-
Copy full SHA for 95de05c - Browse repository at this point
Copy the full SHA 95de05cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6602a60 - Browse repository at this point
Copy the full SHA 6602a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6006fb7 - Browse repository at this point
Copy the full SHA 6006fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 487a17e - Browse repository at this point
Copy the full SHA 487a17eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.