Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few proposed enhancements: #96

Open
lachlansleight opened this issue Jan 14, 2022 · 1 comment
Open

A few proposed enhancements: #96

lachlansleight opened this issue Jan 14, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lachlansleight
Copy link

lachlansleight commented Jan 14, 2022

Hey @lxieyang! Nice extension, thanks for your work on it! :)

I have a couple of things I'd like to add - would love to know what you think. Happy to do all the work on it and do PRs, but obviously not if you wouldn't merge them - if so I'll just make a fork and do it all locally

  • Option to hide the search bar - it takes up quite a lot of space and I'm sure I'm not the only person who has zero interest in it
  • Remove the weird extra 10px of margin on the document body - it makes full-width headers and footers show an ugly gap between them and the sidebar (e.g. GitHub's header)
  • Add position: relative; to the document body, so that absolute-positioned elements don't appear behind the tab bar (this one is important as this breaks many sites, including YouTube!)
  • Option to disable the animation, as I personally find it quite distracting when it slides in every time I go to a new page - plus on pages with lots of content the animation can get a little framey. Also, it's annoying if the tab bar is shown in tab A, then while in tab B it is hidden. When navigating back to tab A, the tab bar first appears, then instantly animates away. It would be better if it was just instantly not there!

What do you reckon? I think the second and third points in particular are very straightforward and really should be done - especially the position: relative fix.

@lxieyang
Copy link
Owner

Sounds good, I could actually work on these great suggestions as I'll have some free time in early 2022. I'll mark these as todos!

Thanks again for your enthusiasm and support! I really appreciate it!

@lxieyang lxieyang added the enhancement New feature or request label Jan 18, 2022
@lxieyang lxieyang self-assigned this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants