Link libz only for static builds #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user is not building libxml2 and is linking to it dynamically, then there is no additional need to link to libz, since libxml2 will be depending on libz anyway.
|
Thanks! |
|
Related Pillow issues: python-pillow/Pillow#3208, python-pillow/Pillow#3209. |
|
I reverted this change for lxml 4.2.3, just released. |
|
But why didn't the 4.2.2 wheels link to libz statically? |
|
Short answer: I don't know, and reverting the change was a much quicker solution than anything else. |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Jul 6, 2018
cliff now has a universal wheel. Remove unused Pipfile.lock files. Skip broken lxml 4.2.2, see lxml/lxml#265 . Fix more oscillating environment markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is not building libxml2 and is linking to it dynamically, then
there is no additional need to link to libz, since libxml2 will be
depending on libz anyway.