isoschematron.Schematron constructor now accepts a Xpath object as validation_errors param #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameters to customize failing behaviour. Standard behaviour is unchanged to keep full backward compatibility. Implementation is also safe in case of complete customization via subclassing Schematron. Docstring and tests updated.
|
looks good to me, too. |
scoder
added a commit
that referenced
this pull request
Feb 28, 2015
isoschematron.Schematron constructor now accepts a Xpath object as validation_errors param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday version was a bit on a rush. I also read Holger's suggestion and went back to give it a try in a proper way.
Now Schematron can be customized in two ways:
Schematron.FAIL_ON_ASSERT_ONLY and Schematron.FAIL_ON_ASSERT_AND_REPORT are there as shortcuts to the relevant XPath objects.
This implementation goes well with the old code for both the default behavior and subclassing approach.