Added lxml.html.CheckboxGroup.value_options property #57

Merged
merged 2 commits into from Jun 26, 2012

Conversation

Projects
None yet
2 participants
@alexey-grom
Contributor

alexey-grom commented Jun 22, 2012

In lxml.html.CheckboxGroup.doc exists description for property .value_options that is not implementated. Added method is the same as in RadioGroup.

@scoder

This comment has been minimized.

Show comment Hide comment
@scoder

scoder Jun 26, 2012

Member

This is lacking tests.

Member

scoder commented Jun 26, 2012

This is lacking tests.

@alexey-grom

This comment has been minimized.

Show comment Hide comment
@alexey-grom

alexey-grom Jun 26, 2012

Contributor

This commit append 7 lines that is not influence for something. Moreover, this code should be there for a long time, since it is documented. I'll search similar tests for RadioGroup, and if they are exists I'll add them.

Contributor

alexey-grom commented Jun 26, 2012

This commit append 7 lines that is not influence for something. Moreover, this code should be there for a long time, since it is documented. I'll search similar tests for RadioGroup, and if they are exists I'll add them.

@scoder

This comment has been minimized.

Show comment Hide comment
@scoder

scoder Jun 26, 2012

Member

I'm inclined to think that the documentation was just a copy&paste oversight. And I do not see the relation between (the potential lack of) tests for RadioGroup and any tests for CheckgroupBox.

But I do agree that this would be helpful, so I'm asking you to finish up your changes (which obviously includes tests) so that I can merge them.

Member

scoder commented Jun 26, 2012

I'm inclined to think that the documentation was just a copy&paste oversight. And I do not see the relation between (the potential lack of) tests for RadioGroup and any tests for CheckgroupBox.

But I do agree that this would be helpful, so I'm asking you to finish up your changes (which obviously includes tests) so that I can merge them.

@alexey-grom

This comment has been minimized.

Show comment Hide comment
@alexey-grom

alexey-grom Jun 26, 2012

Contributor

In tests folder there is no any tests for forms and controls. Should I add this too? Even there is no html file with forms and controls, only one with simple divs (lxml/tests/shakespeare.html).

Contributor

alexey-grom commented Jun 26, 2012

In tests folder there is no any tests for forms and controls. Should I add this too? Even there is no html file with forms and controls, only one with simple divs (lxml/tests/shakespeare.html).

@alexey-grom

This comment has been minimized.

Show comment Hide comment
@alexey-grom

alexey-grom Jun 26, 2012

Contributor

I mean, If I add the tests for it commit that it will have to make too great additions like append html file with

etc. Because there is no other similar tests.

Contributor

alexey-grom commented Jun 26, 2012

I mean, If I add the tests for it commit that it will have to make too great additions like append html file with

etc. Because there is no other similar tests.

@scoder

This comment has been minimized.

Show comment Hide comment
@scoder

scoder Jun 26, 2012

Member

The tests for lxml.html are in

https://github.com/lxml/lxml/tree/master/src/lxml/html/tests/

Most of them use doctests.

Member

scoder commented Jun 26, 2012

The tests for lxml.html are in

https://github.com/lxml/lxml/tree/master/src/lxml/html/tests/

Most of them use doctests.

@alexey-grom

This comment has been minimized.

Show comment Hide comment
@alexey-grom

alexey-grom Jun 26, 2012

Contributor

I think it is finished. Is it fine that commits have same names?

Contributor

alexey-grom commented Jun 26, 2012

I think it is finished. Is it fine that commits have same names?

@scoder

This comment has been minimized.

Show comment Hide comment
@scoder

scoder Jun 26, 2012

Member

I prefer either having tests and feature in the same commit (if they are reasonably small) or giving each separate commit a telling name, e.g. "added tests for new .value_group property" or something like that for the commit with the tests. However, given that this would best have been one commit, I'm fine with having one commit comment for both.

Thanks for the contribution.

Member

scoder commented Jun 26, 2012

I prefer either having tests and feature in the same commit (if they are reasonably small) or giving each separate commit a telling name, e.g. "added tests for new .value_group property" or something like that for the commit with the tests. However, given that this would best have been one commit, I'm fine with having one commit comment for both.

Thanks for the contribution.

scoder added a commit that referenced this pull request Jun 26, 2012

Merge pull request #57 from alexey-grom/master
Added lxml.html.CheckboxGroup.value_options property

@scoder scoder merged commit 57d2b5a into lxml:master Jun 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment