Add support for tag="{*}name" in _Element.iter() and friends. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such methods now have all combinations of wilcards to implement CSS selectors NS|E, |E, *|E, NS|*, |*, and *|* Internally the meaning of the qname.href struct field was changed: * The NULL pointer is a wildcard, matches any namespace * The empty Python byte-string matches elements without a namespace * Other Python byte-strings are namespace URIs, matching elements in the same namespace. qname.c_name is uchanged (NULL for a wildcard, a C string for a given local name.)
| The same change applies to the ``.getiterator()``, ``.itersiblings()``, | ||
| ``.iterancestors()``, ``.iterdescendants()``, ``.iterchildren()`` | ||
| and ``.itertext()`` methods as well as the ``strip_attributes()``, | ||
| ``strip_elements()`` and ``strip_tags()`` functions. |
There was a problem hiding this comment.
Apparently some stuff in iterpase.pxi also uses _MultiTagMatcher, but I’m not sure how that translates into the public API.
There was a problem hiding this comment.
You can pass a tag name into iterparse(), which then behaves essentially like .iter(tag), but during parsing. So it's affected as well.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such methods now have all combinations of wilcards to implement
CSS selectors
NS|E,|E,*|E,NS|*,|*, and*|*Internally the meaning of the qname.href struct field was changed:
the same namespace.
qname.c_name is uchanged (NULL for a wildcard, a C string for a
given local name.)