Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user32: allow setting and unsetting the default item #71

Merged
merged 1 commit into from
May 6, 2019

Conversation

zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented May 4, 2019

MFS_DEFAULT doesn't allow unsetting properly.

zx2c4 added a commit to zx2c4-forks/walk that referenced this pull request May 4, 2019
We can't use MFS_DEFAULT, because items fail to get inserted if it was
ever used once prior, due to an old Windows bug. But we can get the same
thing with SetMenuDefaultItem.

Depends-on: lxn/win#71
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
zx2c4-bot pushed a commit to WireGuard/wireguard-windows that referenced this pull request May 4, 2019
We can't use MFS_DEFAULT, because items fail to get inserted if it was
ever used once prior, due to an old Windows bug. But we can get the same
thing with SetMenuDefaultItem.

Depends-on: lxn/win#71
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
@lxn lxn merged commit 21dd904 into lxn:master May 6, 2019
zx2c4-bot pushed a commit to WireGuard/wireguard-windows that referenced this pull request May 14, 2019
We can't use MFS_DEFAULT, because items fail to get inserted if it was
ever used once prior, due to an old Windows bug. But we can get the same
thing with SetMenuDefaultItem.

Depends-on: lxn/win#71
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
@zx2c4 zx2c4 deleted the jd/default-menu-state branch May 15, 2019 09:21
zx2c4-bot pushed a commit to WireGuard/wireguard-windows that referenced this pull request May 15, 2019
We can't use MFS_DEFAULT, because items fail to get inserted if it was
ever used once prior, due to an old Windows bug. But we can get the same
thing with SetMenuDefaultItem.

Depends-on: lxn/win#71
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants