Python 3.6+ #49
Merged
Python 3.6+ #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Python 3.5 support and modernize the code accordingly.
There are two occurrences of the
flagvariable. In the first case I changed it tobooland renamed tois_in_list(please change if you have better name).In the second case in the
get_initialsmethod this variable is always1(True) and never changes and still is tested: https://github.com/lxneng/xpinyin/blob/master/src/xpinyin/__init__.py#L153-L166 Should I file an issue? The tests don't cover this.