Backlight #237
Merged
Backlight #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirtualBackEnd defined the backlightChanged signal. But the LinuxBackend
inherits VirtualBackEnd and defines the signal again, overriding it.
LXQt::Backlight correctly uses the VirtualBackEnd::backlightChanged signal:
connect(m_backend, &VirtualBackEnd::backlightChanged,
this, &Backlight::backlightChangedSlot);
and that implies that for the LinuxBackend case the backlightChangedSlot
slot is never called. The signal source is LinuxBackend not VirtualBackEnd.
The fix is simple, just delete the LinuxBackend backlightChanged signal.
A user using the LXQt::Backlight would never get the backlightChanged
signal.
luis-pereira
force-pushed
the
backlight
branch
from
44cc1f5
to
9d8e7f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.