Separate idle watchers for AC and Battery #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config and src implementation. First attempt.
- set minimum time - display mm:ss - load right values
- clean up code - ensure discharging state is updated - set a minimum difference on AC/Battery timeout
palinek
requested changes
Jan 18, 2021
| @@ -46,8 +46,10 @@ namespace PowerManagementSettingsConstants | |||
| const QString POWER_LOW_LEVEL_KEY { QL1S("powerLowLevel") }; | |||
| const QString SHOW_ICON_KEY { QL1S("showIcon") }; | |||
| const QString USE_THEME_ICONS_KEY { QL1S("useThemeIcons") }; | |||
| const QString IDLENESS_ACTION_KEY { QL1S("idlenessAction") }; | |||
| const QString IDLENESS_TIME_SECS_KEY { QL1S("idlenessTimeSecs") }; | |||
| const QString IDLENESS_AC_ACTION_KEY { QL1S("idlenessACAction") }; | |||
There was a problem hiding this comment.
One minor note.
In this new version we completely ignore the pre-existing "legacy" configuration.
IMO we should fallback to legacy configuration for both AC/baterry if there is no new configuration defined in the config yet.
E.g. something like
return value(IDLENESS_AC_ACTION_KEY, value(IDLENESS_LEGACY_ACTION_KEY, -1)).toInt();There was a problem hiding this comment.
Ok.
I'm going to set the old values to be the actual settings of both AC/Battery watchers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #60