Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added complete runner style to LXQt's kvantum theme #45

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Oct 27, 2021

Also, made a few corrections/modifications to Panel's style.

Also, made a few corrections/modifications to Panel's style.
@stefonarch
Copy link
Member

It looks fine, but I selection color is black and therefore not so readable but I don't find the reason - it should be white looking at the file no? Also hover remains white:

#commandList::item:hover {
    background: #3c3c3c;
    color: #80C0FF;
 }

schermata-10-27-19-47

@tsujan
Copy link
Member Author

tsujan commented Oct 27, 2021

selection color is black and therefore not so readable

Very strange, for two reasons! First, I can't reproduce it here; the text is white and it doesn't change color with light or dark widget styles. Second, the list style is exactly that of Panel's mainmenu.

If you give me a way of reproducing it, I might be able to find the cause.

Also hover remains white

This problem should be somewhere in the code, not in the style, but it isn't serious.

@tsujan
Copy link
Member Author

tsujan commented Oct 27, 2021

OK, I found a way of reproducing it: with Fusion and with a palette whose selected text color is black.

I should see if the problem is in the theme or in the code. I hope there's time for that before 1.0.0.

@stefonarch
Copy link
Member

stefonarch commented Oct 27, 2021

My findings: "selected item" takes "selected text" from any palette.

EDIT: with any widget style here.

@tsujan
Copy link
Member Author

tsujan commented Oct 27, 2021

My findings: "selected item" takes "selected text" from any palette.

Exactly.

Good news: I found the cause and it was in the theme :) Will add a commit tonight, after a little rest.

And also in line-edits.
@tsujan
Copy link
Member Author

tsujan commented Oct 27, 2021

Done.

I wrote a whole widget style and had to deal with annoying interferences by probable style sheets. Now, the way widget styles may interfere with Qt style sheets surprises me.

@stefonarch
Copy link
Member

I wondered what the issue was, didn't think ofselection-color: never used that. I see most themes are affected in the runner at least by this.

@tsujan
Copy link
Member Author

tsujan commented Oct 28, 2021

I see most themes are affected in the runner at least by this.

Yes, the same thought came to me too. We'll need to fix them if that's the case.

@tsujan tsujan merged commit 7469417 into master Oct 28, 2021
@tsujan tsujan deleted the kvantum_runner branch October 28, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants