Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection color in runner can be hardly readable #46

Closed
stefonarch opened this issue Oct 28, 2021 · 5 comments
Closed

Selection color in runner can be hardly readable #46

stefonarch opened this issue Oct 28, 2021 · 5 comments

Comments

@stefonarch
Copy link
Member

stefonarch commented Oct 28, 2021

It's taken from palette's selection color and sometimes also background is affected.

Issue is present in Ambiance, arch-colors, clearlooks and leech (for both also selection background in qmenu), kde-plasma, silver.

Expected Behavior

Themes should be readable with all palettes.

Current Behavior

Some palettes can lead to unreadable selected item in runner.

Possible Solution

Defining selection colors and background in runner and qmenu.
See #45 (comment)

  • Distribution & Version: latest git
@tsujan
Copy link
Member

tsujan commented Oct 28, 2021

Who will do it? You or I? I ask to prevent duplication of works (I've done nothing yet).

@stefonarch
Copy link
Member Author

I have time only next week, depends on how urgent it is, it should be fixed before 1.0.0 IMHO.
Or we could split the work? I'll do silver and arch-colors?

@tsujan
Copy link
Member

tsujan commented Oct 28, 2021

I think it'll be better done by one dev. Next week will be OK.

BTW, I put 2021-11-04 as the release date in the pre-release PRs but it's just a set of numbers. I've compiled and installed all pre-release branches and think 1.0.0 is OK. If you don't have time next week, please tell me to delay the release; your help is very needed with the site — you know about it much more than I do (I've never touched it).

Last but not least, there is no rush. Any time that's good for you will be good for me too.

@stefonarch
Copy link
Member Author

Ok, I had already a look at silver, which lacked "color" in item list. I'll look at the others.

@stefonarch
Copy link
Member Author

stefonarch commented Dec 5, 2021

This can be closed now, after checking all themes before 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants