-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection color in runner can be hardly readable #46
Comments
Who will do it? You or I? I ask to prevent duplication of works (I've done nothing yet). |
I have time only next week, depends on how urgent it is, it should be fixed before 1.0.0 IMHO. |
I think it'll be better done by one dev. Next week will be OK. BTW, I put 2021-11-04 as the release date in the pre-release PRs but it's just a set of numbers. I've compiled and installed all pre-release branches and think 1.0.0 is OK. If you don't have time next week, please tell me to delay the release; your help is very needed with the site — you know about it much more than I do (I've never touched it). Last but not least, there is no rush. Any time that's good for you will be good for me too. |
Ok, I had already a look at silver, which lacked "color" in item list. I'll look at the others. |
This can be closed now, after checking all themes before 1.0.0 |
It's taken from palette's selection color and sometimes also background is affected.
Issue is present in Ambiance, arch-colors, clearlooks and leech (for both also selection background in qmenu), kde-plasma, silver.
Expected Behavior
Themes should be readable with all palettes.
Current Behavior
Some palettes can lead to unreadable selected item in runner.
Possible Solution
Defining selection colors and background in runner and qmenu.
See #45 (comment)
The text was updated successfully, but these errors were encountered: