Use nullptr #221
Merged
Use nullptr #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujan
reviewed
Feb 7, 2020
src/misc.cpp
Outdated
| @@ -782,7 +782,7 @@ void SearchBox::event_cursor_moved(QMouseEvent *e) { move(e->x(), e->y()); } | |||
|
|
|||
| void SearchBox::event_xbutton_clicked() | |||
| { | |||
| QKeyEvent ke(QEvent::KeyPress, Qt::Key_Escape, 0); // temp.. | |||
| QKeyEvent ke(QEvent::KeyPress, Qt::Key_Escape, nullptr); // temp.. | |||
There was a problem hiding this comment.
Isn't Qt::NoModifier better here, instead of nullptr? The c-tor is:
QKeyEvent(QEvent::Type type, int key, Qt::KeyboardModifiers modifiers, const QString &text = QString(), bool autorep = false, ushort count = 1)There was a problem hiding this comment.
Of course.
And there's some more mistakes.
Will update it and ping you.
There was a problem hiding this comment.
And there's some more mistakes.
I didn't find any.
Will update it and ping you.
OK.
There was a problem hiding this comment.
I was tricked by the variable name: size.... turns out that it's a pointer.
My first pass was right. Updating.
Drop 0 and NULL. It improves type safety and resolves ambiguous situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop 0 and NULL. It improves type safety and resolves ambiguous situations.