Allow to disable drawing line chars #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lxqt/qtermwidget#275
To test it, run this command:
Preferences -> Appearance -> Draw line chars checked:
Unchecked:
Apparently this feature in qtermwidget is broken for at least Chinese characters, and Qt is drawing lines much better.
As the behavior before this patch is equivalent to that option checked, I keep the default checked.
This text file is copied by running
gpg --signwith pinentry program set topinentry-cursesandLC_ALL=zh_TW.UTF-8. There are still two lines runs outside the box. I think it's an pinentry issue.The last word: I think the name "Draw line chars" is confusing unless one is familiar with how qtermwidget works. Need suggestions :)Changed the option name, which is inspired by a similar option in Konsole. The option name should be fine now :)