New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): update the asserts in expired SSL certificate test #1373

Merged

mre merged 1 commit into lycheeverse:master from orhun:fix/update_ssl_cert_tests

Feb 9, 2024

Contributor

orhun commented Feb 9, 2024

I'm getting the following test failure locally while build the latest version for Arch Linux:

-"error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1883: (certificate has expired)"
+String("error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091: (certificate has expired)")

This PR fixes that via performing separate assert checks on the output (since the line number in statem_clnt.c depends on the platform)

I already built the Arch Linux package with this patch but I'm open to other suggestions. Just wanted to bring this up to your attention! 🐻


          fix(tests): update the asserts in expired SSL certificate test

381d368

mre merged commit 13f4339 into lycheeverse:master

7 checks passed

Member

mre commented Feb 9, 2024

no clue what's up with the tests lately. thx for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment