Fix clippy errors #1423
Merged
Fix clippy errors #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current clippy version (v0.1.78) says "you should put bare URLs between `<`/`>` or make a proper Markdown link" and refers to https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Clippy v0.1.78 complains about the IPv6 network mask, insisting that it is missing backticks. So backticks it gets. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Clippy v0.1.78 identifies this as dead code. However, further down in
the same file, there is clearly a user:
impl Handler<Result, Result> for Add {
This might be yet another incarnation of
rust-lang/rust#56750
Let's just mark it as intentionally dead-code, even if this is untrue,
to make clippy happy again.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Thanks! |
|
⭐ for the awesome commit message. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors puzzled me over in #1422, and I split out this PR to fix them.