-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix publish workflow #304
Conversation
@lebensterben Hit approve on the workflow so we can see it go to green? |
@dblock |
Two problems remaining with the build. I enabled CI to build on all branches, don't see any reason not to. It also makes it possible for contributors to run actions on their forks.
It looks like this is supposed to be this way and only published dependencies can only be picked up. I tried using cargo-publish-all that creates a workspace and seems to be designed to solve this, but end up hitting idanarye/rust-typed-builder#57 |
2c5b54c
to
efc8ada
Compare
Oh I see, thx. Let's fix the build first. What do we do about the publishing checker? |
I don't think My plan is to cherry-pick some changes from this PR and then I would like to close the PR and publish a new version of lychee, which should make future builds green for the time being. In the long run I'd very much like a solution that doesn't require publishing lychee-lib if there's an API change. #305 |
0.7.1 is out. 🥳 |
So the problem with this green pipeline is that it checks publication of lychee-bin against the previous version of lychee. So it's fake green. I got a fix coming. |
Attempts at fixing the publish workflow.