Implements --exclude-file

[dblock]

Implemented #302.

This is my first rust code, so talk to me like a 2yo :)

[lebensterben]

I think your original proposal of .lycheeignore is great.
We should make it default.

And this also allows the possibility for per-directory exclusion list.

[dblock]

I think your original proposal of .lycheeignore is great.
We should make it default.

And this also allows the possibility for per-directory exclusion list.

It's a new construct for Lychee, so I think we should think about it more. The thing with things like .gitignore is that git walks the parent path to find the closest .gitignore until it reaches the git root. This won't be possible here, so maybe it's too much magic?

One way to implement that would be to default --exclude-file to .lycheeexclude if that exists. Can be built on top of this PR.

[lebensterben]

The thing with things like .gitignore is that git walks the parent path to find the closest .gitignore until it reaches the git root.

lychee supports 'glob'.
so you can do something like lychee ~/notes/**/*.md.
when expanding the glob pattern it's already walking the directories.

[mre]

Thanks for the PR.
I also like the idea of a .lycheeignore. In contrast to the .gitignore, a .dockerignore will only be parsed from the build context (usually the current directory), so I would not be too concerned about the differences between the implementations as long as we document the behavior and add tests.

As you both mentioned it could be a nice addition in the future.

[mre]

Thanks for adding these additional exclude tests and increasing the test coverage. ❤️

[mre]

I'll merge this now. Expect a new release soon. Created a ticket for discussing the future addition of .lycheeignore at #308.
Thanks for first (but hopefully not last) your contribution @dblock. ⭐ And welcome to the Rust community! 🦀