Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save image urls to its own table; display images in history screen #237

Closed
5 tasks done
lydavid opened this issue Jun 17, 2023 · 0 comments · Fixed by #277
Closed
5 tasks done

Save image urls to its own table; display images in history screen #237

lydavid opened this issue Jun 17, 2023 · 0 comments · Fixed by #277
Labels
enhancement New feature or request

Comments

@lydavid
Copy link
Owner

lydavid commented Jun 17, 2023 •
edited
Loading

mbid to image url table

mbid
image_path Either cover art archive or Spotify

Then we can use this to display images in history and search

TODO

  • create table
  • migrate release and release group cover arts
    • we originally trimmed .jpg, but CAA supports gif, jpg, jpeg, png, htm, html, jpe, jfif and pdf
  • delete release and release group cover art column
  • Note that we are not currently storing the spotify image url, so we always have to make an additional GET call to Spotify. With this change, let's store the artist image url, so only coil has to do a call

Notes

https://developer.spotify.com/documentation/web-api/reference/get-an-artist
Spotify image url looks like: https://i.scdn.co/image/ab67616d00001e02ff9ca10b55ce82ae553c8228

Continuation
@lydavid lydavid mentioned this issue Jun 17, 2023
Closed
7 tasks
@lydavid lydavid changed the title nice to have: linking table between MB id and spotify id mbid to image url table Jun 17, 2023
@lydavid lydavid changed the title mbid to image url table Display images in history and search screen Jun 18, 2023
@lydavid lydavid added the enhancement New feature or request label Jun 18, 2023
@lydavid lydavid changed the title Display images in history and search screen Display images in history screen Jul 3, 2023
@lydavid lydavid changed the title Display images in history screen Save image urls to its own table; display images in history screen Jul 3, 2023
@lydavid lydavid mentioned this issue Jul 3, 2023
Merged
lydavid pushed a commit that referenced this issue Jul 4, 2023
feat: display images in history screen (#277)
8d8dfee 
resolves #237 

- new table to store image urls for any MB entity
- fix MB OAuth redirect for debug version of app. Now we store the release client secret/id as a GH repo secret. And we store the debug ones in our local `secrets.properties`
  - we can now login properly to both debug/release on the same device
lydavid pushed a commit that referenced this issue Jul 18, 2023
@lydavid
feat: display images in history screen (#277)
dbaf4f0 
resolves #237 

- new table to store image urls for any MB entity
- fix MB OAuth redirect for debug version of app. Now we store the release client secret/id as a GH repo secret. And we store the debug ones in our local `secrets.properties`
  - we can now login properly to both debug/release on the same device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: display images in history screen lydavid/MusicSearch
1 participant
@lydavid