Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display images in history screen #277

Merged
merged 7 commits into from
Jul 4, 2023
Merged

feat: display images in history screen #277

merged 7 commits into from
Jul 4, 2023

Conversation

lydavid
Copy link
Owner

@lydavid lydavid commented Jul 3, 2023

resolves #237

  • new table to store image urls for any MB entity
  • fix MB OAuth redirect for debug version of app. Now we store the release client secret/id as a GH repo secret. And we store the debug ones in our local secrets.properties
    • we can now login properly to both debug/release on the same device

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.01 🎉

Comparison is base (52db5c6) 71.72% compared to head (bc96ed3) 71.74%.

❗ Current head bc96ed3 differs from pull request most recent head 00a1c77. Consider uploading reports for the commit 00a1c77 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #277      +/-   ##
============================================
+ Coverage     71.72%   71.74%   +0.01%     
  Complexity      386      386              
============================================
  Files           142      143       +1     
  Lines          5960     5970      +10     
  Branches        975      976       +1     
============================================
+ Hits           4275     4283       +8     
- Misses          979      980       +1     
- Partials        706      707       +1     
Impacted Files Coverage Δ
...in/java/ly/david/mbjc/ui/search/SearchViewModel.kt 91.80% <ø> (ø)
...rc/main/java/ly/david/mbjc/ui/TopLevelViewModel.kt 45.25% <25.00%> (-0.27%) ⬇️
...ly/david/mbjc/ui/artist/ArtistScaffoldViewModel.kt 77.55% <37.50%> (+2.55%) ⬆️
.../releasegroup/details/ReleaseGroupDetailsScreen.kt 61.90% <50.00%> (+0.79%) ⬆️
...avid/mbjc/ui/artist/details/ArtistDetailsScreen.kt 37.70% <66.66%> (+2.11%) ⬆️
...id/mbjc/ui/release/details/ReleaseDetailsScreen.kt 27.20% <66.66%> (+1.18%) ⬆️
...pp/src/main/java/ly/david/mbjc/di/AppDataModule.kt 100.00% <100.00%> (ø)
...src/main/java/ly/david/mbjc/ui/TopLevelScaffold.kt 61.90% <100.00%> (ø)
.../david/mbjc/ui/release/ReleaseScaffoldViewModel.kt 81.91% <100.00%> (-0.20%) ⬇️
...c/ui/releasegroup/ReleaseGroupScaffoldViewModel.kt 91.66% <100.00%> (-0.34%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lydavid lydavid merged commit 8d8dfee into beta Jul 4, 2023
1 check passed
@lydavid lydavid deleted the dl/image-table branch July 4, 2023 00:27
lydavid pushed a commit that referenced this pull request Jul 18, 2023
resolves #237 

- new table to store image urls for any MB entity
- fix MB OAuth redirect for debug version of app. Now we store the release client secret/id as a GH repo secret. And we store the debug ones in our local `secrets.properties`
  - we can now login properly to both debug/release on the same device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save image urls to its own table; display images in history screen
1 participant