-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when refreshing releasing groups and there is a new release group #859
Comments
Tested with Charles by rewriting with an additional release group, then refreshing. I could not reproduce it. |
I was able to repro on debug app. Let's make sure to clear total remote count, and refetch it when refreshing. |
Steps to track down now that I can repro on debug build
release-group inside artist screen causing crash: select *
from release_group
where id = "e289b05a-9094-4a17-956f-04bffbc09427"; only gives me one result cause it's a primary key Run Run Problem is:
removing this will give just 1 result Selecting FixesThe simplest fix is to select But I need to prevent duplicates showing up in SELECT DISTINCT doesn't work when I need it to be distinct on just one column (rg.id): https://stackoverflow.com/a/5585483 AfterthoughtsThis issue actually came up because of an artist credit name change for a release group upstream after refreshing. Any changes in Unicode counts as a new artist according to our app. I thought about deleting the artist credits as well, but decided against it because other entities may still use the artist credit name. We just need to accept that there may exist some erroneous artist credit names in the app. |
Or it might be because a release group was removed. Need to find a way to test for each of these scenarios
The text was updated successfully, but these errors were encountered: