#1316: EC2SubnetInstanceNodeProperties: s/subnet_id/subnetid/ #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
changed the title
kledo-lyft
approved these changes
Jun 18, 2024
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
…ft#1320) Fixes lyft#1316. Fixes a typo where EC2 subnets as known by EC2 instances would have their id in `subnet_id` instead of `subnetid`. This would cause a missing relationship between the subnet and VPC because VPCs attach to subnets using `subnetid`; see https://github.com/lyft/cartography/blob/098d8ca5f4bb172944338dad9df797a36e23485a/cartography/intel/aws/ec2/subnets.py#L50-L51. This PR is the same as lyft#1318 but with tests; getting this fixed asap. See https://lyftoss.slack.com/archives/CTZUQL0KX/p1718644518442939 for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316.
Fixes a typo where EC2 subnets as known by EC2 instances would have their id in
subnet_idinstead ofsubnetid. This would cause a missing relationship between the subnet and VPC because VPCs attach to subnets usingsubnetid; seecartography/cartography/intel/aws/ec2/subnets.py
Lines 50 to 51 in 098d8ca
This PR is the same as #1318 but with tests; getting this fixed asap.
See https://lyftoss.slack.com/archives/CTZUQL0KX/p1718644518442939 for more context.