-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement repeat requests on GSuite #153
Conversation
skiptomyliu
commented
Sep 14, 2019
•
edited
Loading
edited
- We make a lot of requests to GSuite. This makes it more resilient in case of a Google server blip, which we've seen.
- Refactor the transform objects method to be more general to prevent copy-pasta.
@skiptomyliu @tayasteere Can you please provide more information on the failures? Which data is missing and on which function calls? Do we have stack traces available for these failures? Can we repro? Would like to more thoroughly understand and document the failure before adding retries. |
We receive
As soon as that occurs, we break out of the loop and return an empty list. The cleanup script is then run which removes the old entries. I think to make this more resilient we can:
|
Redoing PR with: #169 CLA signing is borked when I re-configured my new laptop and didn't setup my github config yet. |