Fix 808: Error while ingesting elastic_ip_addresses #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonpetgrave64
suggested changes
Apr 21, 2022
There was a problem hiding this comment.
Look's good. But we also need to update the schema docs.
https://github.com/lyft/cartography/blob/master/docs/root/modules/aws/schema.md#elasticipaddress
Thanks for the pointer! |
ramonpetgrave64
approved these changes
Apr 21, 2022
|
@marco-lancini Yes, I had some trouble finding it too. at ryan-lane |
shinya-murakami-paypay
pushed a commit
to paypay/cartography
that referenced
this pull request
May 23, 2022
* Fix 808: Error while ingesting elastic_ip_addresses * Update test suite * Update schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #808