Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes: add support for secrets #979

Merged
merged 13 commits into from Sep 15, 2022
Merged

Kubernetes: add support for secrets #979

merged 13 commits into from Sep 15, 2022

Conversation

p-l-
Copy link
Contributor

@p-l- p-l- commented Sep 14, 2022

No description provided.

@p-l- p-l- force-pushed the enh-k8s-secrets branch 2 times, most recently from 9d3bfb2 to 54a849c Compare September 14, 2022 16:38
@ramonpetgrave64
Copy link
Contributor

Great to have this! Can you add an integration test and update the schema documentaion?

@p-l-
Copy link
Contributor Author

p-l- commented Sep 15, 2022

@ramonpetgrave64 sure, will do!

@p-l-
Copy link
Contributor Author

p-l- commented Sep 15, 2022

Should be all set now @ramonpetgrave64. Thanks a lot for your reviews!

@ramonpetgrave64
Copy link
Contributor

One more place for docs update

cartography/docs/root/modules/kubernetes/index.rst

Line 4 in 5e3955d

The kubernetes module has the following coverage:

@ramonpetgrave64
Copy link
Contributor

ramonpetgrave64 commented Sep 15, 2022 •
edited

Almost forgot: please add a cleanup job.

@p-l-
Copy link
Contributor Author

p-l- commented Sep 15, 2022

I think I covered all your remarks here. Thanks!

@p-l-
Copy link
Contributor Author

p-l- commented Sep 15, 2022

(+ rebased)

@ramonpetgrave64
Copy link
Contributor

@ryan-lane @marco-lancini

ryan-lane
ryan-lane approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@ryan-lane ryan-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks for the PR!

@ramonpetgrave64 ramonpetgrave64 merged commit c46270a into lyft:master Sep 15, 2022
@p-l- p-l- deleted the enh-k8s-secrets branch September 19, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-lane ryan-lane ryan-lane approved these changes

@ramonpetgrave64 ramonpetgrave64 ramonpetgrave64 approved these changes

@marco-lancini marco-lancini Awaiting requested review from marco-lancini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p-l- @ramonpetgrave64 @ryan-lane