Provide operator configuration via FLINK_PROPERTIES fixes #135 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweise
requested review from
anandswaminathan,
glaksh100,
kumare3 and
mwylde
as code owners
tweise
force-pushed
the
dockerFlinkContainer
branch
from
f1e8ae6
to
9d99a4c
Compare
glaksh100
reviewed
Dec 23, 2019
|
Just to understand correctly, We are changing from |
|
@anandswaminathan yes, we can remove |
tweise
force-pushed
the
dockerFlinkContainer
branch
from
0ed3372
to
dac7cce
Compare
glaksh100
approved these changes
Dec 24, 2019
|
This change will cause applications to restart, right (since the hash has changed)? |
|
@glaksh100 thanks for pointing this out, a noted it in the commit message. |
rjbordon
added a commit
to rjbordon/flinkk8soperator
that referenced
this pull request
Aug 4, 2020
…ted as part of PR lyft#149].
anandswaminathan
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Minor/cosmetics changes on documentation. * Fixing link to non-existing file [docker-entrypoint.sh which was deleted as part of PR #149].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old environment variable is retained for a transition period. The docker-flink containers now support environment variable substitution as well, so we can get rid of the custom entry point!