Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JSDoc compatibility with clojurescript-1934 #21

Merged
merged 1 commit into from
Oct 14, 2013
Merged

Fixes JSDoc compatibility with clojurescript-1934 #21

merged 1 commit into from
Oct 14, 2013

Conversation

sfnelson
Copy link
Contributor

The closure compiler used by clojurescript-1934 ignores the @constructor annotation on Unify and Ignore due to the ';' character that coffeescript inserts after a block comment generated with ``. This patch uses ### comments instead to generate closure-compatible JSDoc annotations.

The closure compiler used by clojurescript-1934 ignores the @constructor annotation on Unify and Ignore due to the ';' character that coffeescript inserts after a block comment generated with ``. This patch uses ### comments instead to generate closure-compatible JSDoc annotations.
@lynaghk
Copy link
Owner

lynaghk commented Oct 14, 2013

Boss, thanks!

lynaghk added a commit that referenced this pull request Oct 14, 2013
Fixes JSDoc compatibility with clojurescript-1934
@lynaghk lynaghk merged commit 856fa1a into lynaghk:master Oct 14, 2013
@lynaghk
Copy link
Owner

lynaghk commented Oct 14, 2013

Just updated 0.1.7-SNAPSHOT on clojars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants