Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure key vault lookup key #34

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Conversation

hbuckle
Copy link
Collaborator

@hbuckle hbuckle commented Aug 5, 2019

Adds a new lookup key function for retrieving values from Azure key vault

@thallgren
Copy link
Contributor

This looks great on a first glance but I'm currently on vacation. Will review in detail on Thursday.

Copy link
Contributor

@thallgren thallgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

This PR highlights the need for Hiera to allow plugins so that added functionality can be configured without the need of added dependencies in the go.mod. Moving forward, additions like this should come in separate modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants