Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Commit

Permalink
fix code-review markdown
Browse files Browse the repository at this point in the history
  • Loading branch information
KlavierCat committed Mar 27, 2017
1 parent 9b6c2f7 commit efec1b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code-reviews/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ However, code reviews start with a pull request, and that means you have a respo

You should read over your own code, make sure you didn't omit any files, check for style errors and so on. You should do this before you create the PR.

####Keep your changes small
#### Keep your changes small

Small changes are much easier to review. They're also much easier to explain to people. This means that mistakes are less likely to sneak through and the discussion of the change should be much more productive. It also means your PR should avoid ending up with tens of comments that go round and round in circles without ever getting your code merged. It is not always possible to break a change up into small parts but it very often is. A good guideline for this is that your change should not effect a combined total of more than 400 lines.

Expand Down

0 comments on commit efec1b9

Please sign in to comment.