Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From Js to Typescript + Modernize the build system #15

Closed
wants to merge 3 commits into from
Closed

From Js to Typescript + Modernize the build system #15

wants to merge 3 commits into from

Conversation

luxluth
Copy link
Contributor

@luxluth luxluth commented Apr 22, 2023 •
edited

why ?

I like this package and I wanted to use it with Svelte framework, and I have some weird errors related to webpack.

Nothing has changed, just better.

What I did:

  • Swapping out webpack to rollup 🔥🔥
  • Adding tsup for node build and better declaration file
  • Changing the exports in the package.json

@luxluth luxluth marked this pull request as draft April 22, 2023 22:37
@luxluth luxluth marked this pull request as ready for review April 22, 2023 22:40
lyswhut added a commit that referenced this pull request Apr 23, 2023
@lyswhut
From Js to Typescript + Modernize the build system (#15)
8c36616
@lyswhut
Copy link
Owner

lyswhut commented Apr 23, 2023

Thanks for your PR, I implemented it in another way based on your PR :)

@luxluth luxluth closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luxluth @lyswhut